remove some options #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ethan Lee <[email protected]>
Signed-off-by: Ethan Lee <[email protected]>
Signed-off-by: Ethan Lee <[email protected]>
Signed-off-by: Ethan Lee <[email protected]>
Signed-off-by: Ethan Lee <[email protected]>
Signed-off-by: Ethan Lee <[email protected]>
Signed-off-by: Ethan Lee <[email protected]>
Signed-off-by: Ethan Lee <[email protected]>
Signed-off-by: Ethan Lee <[email protected]>
ethanleelge
force-pushed
the
remove_opt
branch
from
3c533e9 to
2512039
Compare
Signed-off-by: Ethan Lee <[email protected]>
Signed-off-by: Ethan Lee <[email protected]>
Signed-off-by: Ethan Lee <[email protected]>
Signed-off-by: Ethan Lee <[email protected]>
Signed-off-by: Ethan Lee <[email protected]>
Signed-off-by: Ethan Lee <[email protected]>
Signed-off-by: Ethan Lee <[email protected]>
Signed-off-by: Ethan Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove some options
[Option: -b, -n, -c]
Checked whether the Binary name is included in NOTICE.html.
This step is unnecessary as the inclusion of notice is checked through the FL Hub.
[Option: -t]
For binaries where NOTICE is located in the source code path but not added to NOTICE.html, NOTICE is aggregated.
This can be handled using the Supplement feature of FL Hub.
[Option: -d]
The needtoadd-notice.html file is divided by binary.
This can also be managed using the Supplement feature of FL Hub.
Type of change