Skip to content

Remove unnecessaries #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Remove unnecessaries #43

wants to merge 5 commits into from

Conversation

@ethanleelge
Copy link
Contributor

@ethanleelge ethanleelge commented Mar 20, 2025

Description

  1. Remove imports : run_notice_html_checklist, divide_notice_files_by_binary
  2. Remove comments : android_binary_analysis.py line 894
  3. Remove comments : check_notice_file.py line 99, line 106 ~ 120
  4. Restore parameter : android_binary_analysis.py line 895, add sort_keys

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@ethanleelge ethanleelge added the chore [PR/Issue] Refactoring, maintenance the code label Mar 20, 2025
@ethanleelge ethanleelge requested a review from dd-jy March 20, 2025 01:49
@ethanleelge ethanleelge self-assigned this Mar 20, 2025
@ethanleelge ethanleelge changed the title Remove unnecessary comments and unused function imports Remove unnecessary comments and imported functions Mar 20, 2025
@ethanleelge ethanleelge changed the title Remove unnecessary comments and imported functions Remove unnecessaries Mar 20, 2025
@ethanleelge ethanleelge force-pushed the ethan_after_review branch 3 times, most recently from 5436fb8 to 77f10fa Compare March 20, 2025 02:00
@ethanleelge
Remove unnecessaries
c8a9bd1 
Signed-off-by : Ethan Lee <[email protected]>
@ethanleelge
Remove unecessaries
0ed599e 
Signed-off-by: Ethan Lee <[email protected]>
@ethanleelge
Apply flake8 for test
b416f4c 
Signed-off-by: Ethan Lee <[email protected]>
@ethanleelge ethanleelge deleted the ethan_after_review branch March 20, 2025 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dd-jy dd-jy Awaiting requested review from dd-jy

Assignees

@ethanleelge ethanleelge

Labels

chore [PR/Issue] Refactoring, maintenance the code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ethanleelge