Skip to content

Conversation

@s-cu-bot
Copy link
Contributor

@s-cu-bot s-cu-bot commented Sep 14, 2024

Description

[What I changed]
(1) requirements-dev.txt

  • Added pytest-xdist
  • pytest plugin that supports parallel processing

(2) file_format_test.py

  • "setup_test_result_dir_and teardown" is a logic to temporarily create a test directory and then delete it when the test ends.
  • "run_command" is a function that helps you execute Linux commands (prints success and result values)
  • "test_output_file_format" checks whether files are created normally in excel, csv, json, and yaml format.

(3) initial_tox_test.py

  • "setup_test_result_dir_and teardown", "run_command" are the same as file_format_test.py
  • “test_release_environment”, "test_test_run_environment" are the same as the existing tox process.
  • Only refactoring is performed through pytest (errors can be checked through assert statements, and additional verification is possible)

(4) tox.ini

  • Change the entire test code running in the file on a file/function basis.
  • Parallel execution of test cases via pytest (-n flag)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@s-cu-bot s-cu-bot marked this pull request as ready for review September 22, 2024 13:35
@soimkim soimkim added the chore [PR/Issue] Refactoring, maintenance the code label Sep 28, 2024
Copy link

@cjho0316 cjho0316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@YongGoose YongGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔끔하게 잘 해주신 것 같습니다 :)

많이 배우고 갑니다.

Copy link

@ena-isme ena-isme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

많은 참고가 되었습니다:) 수고하셨어요!

Copy link

@MoonJeWoong MoonJeWoong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 크게 고칠만한 부분은 보이지 않는 것 같아서 코멘트 달아주신 부분만 확인해주시면 될 것 같습니다~

@soimkim soimkim merged commit 84200ac into fosslight:main Oct 3, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore [PR/Issue] Refactoring, maintenance the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants