Enhance fosslight_wrapper.py with double-click functionality and manual mode #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: 더블클릭 시 현재 경로 분석 및 결과 도출 기능 추가 * feat: --manual 옵션으로 사용자 지정 설정 가능하도록 구현 * refactor: 실행 모드에 따른 로직 분리 Signed-off-by: soonhong99 <[email protected]>
Contributor
Author
|
#123 해당 PR 내용에 이어 만들어진 PR입니다. |
Signed-off-by: soonhong99 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the existing
fosslight_wrapper.pyfile with new functionalities:fosslight_wrapper.exe --manualallows users to specify custom image, options, analysis path, and output path.These changes aim to improve user experience by providing more flexible usage options.
Changes made:
This PR continues and enhances the work from the previous PR on fosslight_wrapper.py.
Current issues and considerations:
WFP file generation: The
scanner_output.wfpfile is still generated in the analysis directory when run on Windows, both in double-click and manual modes. It's worth noting that this issue also occurs when using 'pip install fosslight_scanner', indicating it's not specific to the Docker wrapper.Self-analysis of executable: When analyzing the current directory via double-click, the
fosslight_wrapper.exeitself is included in the analysis. We need to consider how to exclude the executable from the analysis to prevent unnecessary scanning.Next steps:
We welcome any feedback or suggestions on addressing these issues and further improving the wrapper's functionality.
Type of change
Please insert 'x' one of the type of change.