Skip to content

Conversation

@soonhong99
Copy link
Contributor

Description

This PR removes the following line from requirements.txt:
typecode-libmagic;sys_platform!="darwin"
Reason for removal:
The typecode-libmagic package was causing installation errors in our Docker environment. This dependency is not essential for the core functionality of our project and was leading to build failures.

Changes made:

Deleted the line specifying typecode-libmagic from requirements.txt

Impact:

Resolves Docker build failures related to this package
May affect file type detection capabilities in non-Darwin environments (if this feature was being used)

Next steps:

Monitor for any unintended side effects in file type detection (if applicable)
Consider alternative solutions for file type detection if needed in the future

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@soimkim soimkim added the chore [PR/Issue] Refactoring, maintenance the code label Oct 13, 2024
@soimkim soimkim merged commit f4f859a into fosslight:main Oct 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore [PR/Issue] Refactoring, maintenance the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants