Skip to content

Refactor existing tox test to pytest #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 3, 2024
Merged

Refactor existing tox test to pytest #189

merged 13 commits into from
Oct 3, 2024

Conversation

@MoonJeWoong
Copy link
Contributor

@MoonJeWoong MoonJeWoong commented Sep 27, 2024 •
edited
Loading

Description

Refactor the existing tox test code to pytest.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@MoonJeWoong
refactor test_text.py
7270050 
Signed-off-by: MoonJeWoong <[email protected]>
@MoonJeWoong
refactor test_write_output.py, test_output_format.py
978cc24 
Signed-off-by: MoonJeWoong <[email protected]>
@MoonJeWoong
refactor test_spdx_licenses.py
693352e 
Signed-off-by: MoonJeWoong <[email protected]>
@MoonJeWoong
rename temp pytest package
a6cdb5e 
Signed-off-by: MoonJeWoong <[email protected]>
@MoonJeWoong
add init file to legacy package
50fcaad 
Signed-off-by: MoonJeWoong <[email protected]>
@MoonJeWoong
refactor test_download.py
d0694e8 
Signed-off-by: MoonJeWoong <[email protected]>
@MoonJeWoong
refactor test_write_yaml.py
051f156 
Signed-off-by: MoonJeWoong <[email protected]>
@MoonJeWoong
refactor test_opossum.py
cc950e9 
Signed-off-by: MoonJeWoong <[email protected]>
@MoonJeWoong
refactor legacy tox test files related for logging
c6c8fcf 
Signed-off-by: MoonJeWoong <[email protected]>
@MoonJeWoong MoonJeWoong marked this pull request as draft September 27, 2024 18:35
@soimkim soimkim added the chore [PR/Issue] Refactoring, maintenance the code label Sep 28, 2024
@soimkim soimkim marked this pull request as ready for review September 28, 2024 08:19
cjho0316
cjho0316 reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@cjho0316 cjho0316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 검증로직과 코드스타일이 깔끔해서 술술읽히는게 좋았습니다. 한수 배워갑니다!

ena-isme
ena-isme reviewed Oct 1, 2024
View reviewed changes
Copy link

@ena-isme ena-isme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 :) 😊

s-cu-bot
s-cu-bot approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@s-cu-bot s-cu-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

특이사항 없습니다. 고생하셨습니다~~

hkkim2021
hkkim2021 reviewed Oct 1, 2024
View reviewed changes
Copy link

@hkkim2021 hkkim2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 보면서 많이 배웠습니다! 수고하셨습니다 :)

YongGoose
YongGoose reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@YongGoose YongGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔끔하게 잘 작성해주셨네요 :)
고생하셨습니다 👍

@MoonJeWoong
reformat import statements
666f81f 
Signed-off-by: MoonJeWoong <[email protected]>
@soimkim soimkim merged commit 751a89d into fosslight:main Oct 3, 2024
3 of 4 checks passed
@soimkim soimkim mentioned this pull request Oct 10, 2024
Closed
5 tasks
@dd-jy dd-jy mentioned this pull request Mar 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soimkim soimkim soimkim approved these changes

+5 more reviewers

@cjho0316 cjho0316 cjho0316 left review comments

@ena-isme ena-isme ena-isme left review comments

@YongGoose YongGoose YongGoose left review comments

@hkkim2021 hkkim2021 hkkim2021 left review comments

@s-cu-bot s-cu-bot s-cu-bot approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MoonJeWoong MoonJeWoong

Labels

chore [PR/Issue] Refactoring, maintenance the code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@MoonJeWoong @soimkim @cjho0316 @ena-isme @YongGoose @s-cu-bot @hkkim2021