feat(auth): replace expires_in with expires_at for token expiry #199
+98
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: aaryan359 <[email protected]>
Author
|
@deo002 Please check this? Does it looks good? |
deo002
requested changes
Feb 11, 2026
Collaborator
deo002
left a comment
deo002
left a comment
There was a problem hiding this comment.
Thanks for your contributions! Some changes are required.
| } | ||
|
|
||
| expiresInSeconds := int64(accessTokenLifespan * 3600) | ||
| expiresAt := now.Add(time.Second * time.Duration(expiresInSeconds)) |
Collaborator
There was a problem hiding this comment.
Please use the same value here that is used for the creation of the access token at line 1093
| t.Fatalf("invalid expires_at format: %v", err) | ||
| } | ||
|
|
||
| min := before.Add(59 * time.Minute) |
Collaborator
There was a problem hiding this comment.
Isn't this configurable in the .env.test.example file and the test would fail if I change it? Also, let's not check it this way. We have a field called iat in the token. We can get the exact expiry date by adding the lifespan set in the .env file to the issued_at attribute.
| } | ||
|
|
||
| // Expect ~1 hour validity again | ||
| min := before.Add(59 * time.Minute) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed in this fossology/LicenseDb-UI#26, I updated the expire_in logic to expire_at, and also created a PR in the frontend fossology/LicenseDb-UI#54
Changes
expires_atfield for access tokensexpires_inSubmitter Checklist
References
N/A