-
Notifications
You must be signed in to change notification settings - Fork 31
[dpp] store enforce_sizes in log name and added generic kwargs to get_default_validation_prefix #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| return "_".join(formatted_pairs) | ||
|
|
||
|
|
||
| def get_default_validation_prefix( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test utilizing the sampler key for this function
1fe0aaa to
96f5774
Compare
|
bot:test |
…_default_validation_prefix, enable sample_key Signed-off-by: kcirred <[email protected]>
…uad_v2 sampler Signed-off-by: kcirred <[email protected]>
Signed-off-by: kcirred <[email protected]>
5ade172 to
2f69fa3
Compare
…oo long Signed-off-by: kcirred <[email protected]>
Signed-off-by: kcirred <[email protected]>
Signed-off-by: kcirred <[email protected]>
JRosenkranz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
bot:test |
Signed-off-by: kcirred <[email protected]>
format_kwargs_to_stringfor easier conversion of kwargs into stringget_validation_info_pathto get string with enforce_sizes in log name