Skip to content

Conversation

@kcirred
Copy link
Collaborator

@kcirred kcirred commented Sep 22, 2025

  • added new function format_kwargs_to_string for easier conversion of kwargs into string
  • introduced kwargs to get_default_validation_prefix in case future variables needs to be added to function
  • used additional enforce_sizes variable in dpp in get_validation_info_path to get string with enforce_sizes in log name
  • added return_keys to samplers such as sample_rag_factoid_requests and sample_sharegpt_requests, default value False, this allows the returning of a sample_key(str) which contains the exact values used
  • in dpp changed sampler inside __prepare_inputs to use return_key True, returning a sample_key which is then used when storing the log name

@kcirred kcirred requested a review from JRosenkranz September 22, 2025 13:53
@kcirred kcirred self-assigned this Sep 22, 2025
return "_".join(formatted_pairs)


def get_default_validation_prefix(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test utilizing the sampler key for this function

@kcirred kcirred force-pushed the enforce_log branch 3 times, most recently from 1fe0aaa to 96f5774 Compare September 26, 2025 22:00
@JRosenkranz
Copy link
Contributor

bot:test
TEST_FILE=test_scripts.py

Copy link
Contributor

@JRosenkranz JRosenkranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JRosenkranz
Copy link
Contributor

bot:test
TEST_FILE=test_decoders.py MODEL_ID=ibm-granite/granite-3.3-8b-instruct BATCH_SIZE=1 SEQUENCE_LENGTH=2048 USE_TINY_MODEL=1

@JRosenkranz JRosenkranz merged commit 992e612 into foundation-model-stack:main Oct 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants