automate generating cuda/cpu metrics from DPP#156
Open
JRosenkranz wants to merge 7 commits intomainfrom
Open
Conversation
Signed-off-by: Joshua Rosenkranz <jmrosenk@us.ibm.com>
Signed-off-by: Joshua Rosenkranz <jmrosenk@us.ibm.com>
Signed-off-by: Joshua Rosenkranz <jmrosenk@us.ibm.com>
Contributor
Author
|
bot:test |
Contributor
Author
|
bot:test |
Collaborator
|
bot:test |
Collaborator
|
bot:test |
Signed-off-by: Joshua Rosenkranz <jmrosenk@us.ibm.com>
Contributor
Author
|
bot:test |
Contributor
Author
|
bot:test |
Signed-off-by: Joshua Rosenkranz <jmrosenk@us.ibm.com>
Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com>
Ssukriti
reviewed
Jan 7, 2026
|
|
||
| parser.add_argument( | ||
| "--cross_entropy_threshold", | ||
| "--default_cross_entropy_threshold", |
Contributor
There was a problem hiding this comment.
lets not change the argument name, as this is a breaking change and too many teams have adopted DPP. We dont have documentation yet . I am reverting it back as its not a necessary change
Ssukriti
reviewed
Jan 9, 2026
| distributed_kwargs = {} | ||
| if USE_DISTRIBUTED: | ||
| if generate_metrics: | ||
| torch.cuda.set_device(local_rank) |
Contributor
There was a problem hiding this comment.
I ran into a blocker testing this PR as the machines in our cluster do not have GPUs. I think to generate the metrics file for every new model, it will be a challenge from CI/CD perspective as we do not have access to GPU machines. So need to think about this a bit
Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a method to generate metrics from DPP which will fully match the testing workflow. It also includes parameters to take in the generated metrics file and produce the proper assertions per test run.
To run this with generate_metrics requires the following PR foundation-model-stack/foundation-model-stack#481