Fix Missing Import#187
Open
alex-jw-brooks wants to merge 1 commit intofoundation-model-stack:mainfrom
Open
Conversation
Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com>
matthew-pisano
approved these changes
Feb 12, 2026
Collaborator
matthew-pisano
left a comment
matthew-pisano
left a comment
There was a problem hiding this comment.
I noticed this as well, looks good.
Collaborator
|
@Ssukriti @JRosenkranz Any issue with merging this in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the torch functional API is used when sampling is enabled in paged attention, but not imported - probably from copying from FMS and tweaking the generate implementation.
Adds it to prevent import errors if sampling is turned off.