fix(deps): Copy KHD imports into scattermoe_utils
#127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Will Johnson <[email protected]>
Signed-off-by: Will Johnson <[email protected]>
Signed-off-by: Will Johnson <[email protected]>
Signed-off-by: Will Johnson <[email protected]>
Signed-off-by: Will Johnson <[email protected]>
Signed-off-by: Will Johnson <[email protected]>
Signed-off-by: Will Johnson <[email protected]>
fabianlim
reviewed
Feb 21, 2025
| @@ -0,0 +1,349 @@ | |||
| # Third Party | |||
Contributor
There was a problem hiding this comment.
haev a line here that references cute kernels would be good.
fabianlim
reviewed
Feb 21, 2025
| @@ -0,0 +1,310 @@ | |||
| # Copyright The FMS HF Tuning Authors | |||
| # Copyright 2024 Databricks | |||
Contributor
There was a problem hiding this comment.
this file is not from databricks, it is from cute kernels
fabianlim
reviewed
Feb 21, 2025
| import triton.language as tl | ||
|
|
||
| BLOCK_M = 128 | ||
|
|
Contributor
There was a problem hiding this comment.
same here this is from cute kernels
fabianlim
approved these changes
Feb 21, 2025
Contributor
fabianlim
left a comment
fabianlim
left a comment
There was a problem hiding this comment.
LGTM just some minor changes
Signed-off-by: Will Johnson <[email protected]>
Signed-off-by: Will Johnson <[email protected]>
Signed-off-by: Will Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scatter MoE has been using kernel hyperdrive as an external dependency since it's not a pypi library, which makes installation more difficult. Therefore we copy the functions we depend on into
scattermoe_utils.khdto remove this dependency.