chore: Move dcp to safetensors to a wrapper function for downstream usage #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmehant
force-pushed
the
moe-hf-chkpt
branch
4 times, most recently
from
b2f6f62 to
be45088
Compare
Contributor
|
@kmehant actually this design goes agains the ADR. we purposedly did not want fms-acceleration to modify the trainer. I feel the callback should be better installed in fms-hf-tuning |
kmehant
force-pushed
the
moe-hf-chkpt
branch
3 times, most recently
from
196cca5 to
b18be35
Compare
Signed-off-by: Mehant Kammakomati <[email protected]>
kmehant
changed the title
Collaborator
Author
|
@fabianlim requesting your review. Thanks |
fabianlim
approved these changes
Mar 6, 2025
Contributor
fabianlim
left a comment
fabianlim
left a comment
There was a problem hiding this comment.
thanks for taking my comment into account to not change the API. LGTM
Collaborator
Author
|
@fabianlim or @willmj Shall we merge this? |
Contributor
|
Let @willmj look at it first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a wrapper function to wrap complete dcp to safetensor logic in order to enable easy downstream usage through this function without needing to redundantly repeat the same set of steps.