Skip to content

Conversation

@kmehant
Copy link
Collaborator

@kmehant kmehant commented Apr 14, 2025

dtype_byte_size is no more supported in transformers due to its inaccuracies - huggingface/transformers#37144 and related issues.

We should move to torch native solution element_size().

Signed-off-by: Mehant Kammakomati <[email protected]>
@kmehant kmehant requested a review from fabianlim as a code owner April 14, 2025 12:13
@kmehant kmehant requested a review from willmj April 14, 2025 12:14
Copy link
Collaborator

@willmj willmj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@fabianlim fabianlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes looks good.

@kmehant kmehant merged commit afbf918 into foundation-model-stack:main Apr 23, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants