fix: Update QuantLinear import to GPTQLoraLinear #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renaming QuantLinear to GPTQLoraLinear to match the changes made in the peft library. Signed-off-by: Luka Dojcinovic <[email protected]>
fabianlim
approved these changes
Jun 6, 2025
Contributor
fabianlim
left a comment
fabianlim
left a comment
There was a problem hiding this comment.
im ok with this.. but it might make sense to lower bound the version of PEFT, since this will cause regression breakages.
Updated dependencies to include peft>=0.15 Signed-off-by: Luka Dojcinovic <[email protected]>
Contributor
Author
|
Thanks Fabian, I have pushed a new commit specifying |
Signed-off-by: Will Johnson <[email protected]>
Signed-off-by: Will Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to resolve this issue with dependabot updating to a new version of the
peftlibrary. The update has not been merged as it is encountering the following error:Turns out this is because
QuantLinearhas been renamed toGPTQLoraLinearin the newer version ofpeft. This can be seen in this commit.So I have changed the import statement to import
GPTQLoraLinearand modified the code not to useLoraLinearGPTQanymore, as I felt it was pretty similar to the base class name which we could use instead.Please let me know your thoughts.