Adding path prefixes so that llm-d deployments are compatible #523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evaline-ju
reviewed
Jan 6, 2026
Collaborator
evaline-ju
left a comment
evaline-ju
left a comment
There was a problem hiding this comment.
Thanks for the contribution! One clarifying question, and could you make sure to sign off for the DCO (https://github.com/foundation-model-stack/fms-guardrails-orchestrator/pull/523/checks?check_run_id=59587610923)
evaline-ju
approved these changes
Jan 6, 2026
Collaborator
evaline-ju
left a comment
evaline-ju
left a comment
There was a problem hiding this comment.
LGTM if DCO is resolved
Signed-off-by: m-misiura <mmisiura@redhat.com>
m-misiura
force-pushed
the
path-prefix-for-llmd
branch
from
06f5b2b to
43a69f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
llm-ddeployments differ fromvllmones and are usually of the form:When configuring the orchestrator with such a model, the current implementation only supports
hostname:portand doesn't handle path prefixes, making it impossible to connect to llm-d services.To tackle this, I added optional
path_prefixfield to ServiceConfig to support endpoints with path components before the API paths.Test plan
Built an image: quay.io/rh-ee-mmisiura/fms-orchestr8-nlp:path_prefix_4_llmd_v0.1 and