Skip to content

Conversation

@Luka-D
Copy link
Contributor

@Luka-D Luka-D commented Nov 21, 2024

Description of the change

After running tuning locally, the results are saved in a folder /outputs. This folder is always listed as a change when I want to make commits. To solve this I have added /outputs to the .gitignore file. If it is intended to be able to commit the /outputs folder for certain reasons, please let me know and I will delete this PR.

Related issue number

No related issue.

How to verify the PR

Run tuning locally using:
python3 tuning/sft_trainer.py
--model_name_or_path Maykeye/TinyLLama-v0
--training_data_path tests/data/twitter_complaints_small.jsonl
--output_dir outputs/lora-tuning
--num_train_epochs 5
--per_device_train_batch_size 4
--gradient_accumulation_steps 4
--learning_rate 1e-5
--response_template "\n### Label:"
--dataset_text_field "output"
--use_flash_attn false
--torch_dtype "float32"
--peft_method "lora"
--r 8
--lora_dropout 0.05
--lora_alpha 16
--log_level "error"

Then, verify that your output folder isn't shown when running git status or when trying to commit using GitHub Desktop.

Was the PR tested

I ran tuning locally and checked git status, output folder was not listed as something to commit.

  • I have added >=1 unit test(s) for every new method I have added.
  • I have ensured all unit tests pass
    I ran tox -e py and had 187 passed, no failed.

@github-actions
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@Luka-D Luka-D changed the title Added outputs folder to gitignore feat: Added outputs folder to gitignore Nov 21, 2024
@github-actions github-actions bot added the feat label Nov 21, 2024
@Luka-D Luka-D force-pushed the feat-add-to-gitignore branch from e35f040 to 12379c7 Compare November 22, 2024 14:18
@Luka-D Luka-D force-pushed the feat-add-to-gitignore branch from b9f7d8f to ede8868 Compare November 22, 2024 16:12
@Luka-D Luka-D force-pushed the feat-add-to-gitignore branch from ede8868 to 26038a2 Compare November 22, 2024 16:25
@Luka-D Luka-D closed this Nov 22, 2024
@Luka-D Luka-D deleted the feat-add-to-gitignore branch December 13, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant