Skip to content

Conversation

@dushyantbehl
Copy link
Collaborator

@dushyantbehl dushyantbehl commented Nov 29, 2024

Description of the change

The test datasets residing in tests/data folder should be moved to tests/arifacts directory to keep all test artifacts at one location, and keep the folders under tests/ directory contain only test code other than a singe artifact folder.

In this light renames tests/data to tests/artifacts/testdata and make minor changes to test case utilising the test data.

Related issue number

N/A

How to verify the PR

Run make to ensure all fmt lint and tests pass.

Was the PR tested

Tested by ensuring all test cases pass.

  • I have ensured all unit tests pass

@github-actions
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@dushyantbehl dushyantbehl changed the title Move test datasets to tests/artifacts/testdata instead of tests/data fix: Move test datasets to tests/artifacts/testdata instead of tests/data Nov 29, 2024
@github-actions github-actions bot added the fix label Nov 29, 2024
@dushyantbehl dushyantbehl mentioned this pull request Nov 29, 2024
2 tasks
Copy link
Collaborator

@willmj willmj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willmj willmj merged commit 268ac80 into foundation-model-stack:main Dec 3, 2024
8 of 10 checks passed
@dushyantbehl dushyantbehl deleted the rename-test-folder branch December 3, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants