fix: Limit trl version to <0.12 #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishek <[email protected]>
Abhishek-TAMU
requested review from
Ssukriti,
aluu317,
anhuong,
fabianlim and
kmehant
as code owners
|
Thanks for making a pull request! 😃 |
anhuong
approved these changes
Dec 6, 2024
Collaborator
anhuong
left a comment
anhuong
left a comment
There was a problem hiding this comment.
For more detail, since transformers is currently set to <4.46, trl>=0.12 was not being picked up due to trl 0.12.0 and 0.12.1 relying on trl version>4.46. But since trl 0.12.2 was released today the dep limit was changed to rely on transformers<4.47 which allowed us to pick up new trl version. Although Abhishek had tested on previous trl version for the release which is why we are lowering the limit. In addition, we are hitting into error when upgrading trl as seen here
@Abhishek-TAMU let's create an issue for upgrading trl to track this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Limit trl version to <0.12 due to transformers dependency change in TRL v0.12.2
Related issue number
How to verify the PR
Was the PR tested