fix: save model dir hf moe checkpoint #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Will Johnson <[email protected]>
Signed-off-by: Will Johnson <[email protected]>
Signed-off-by: Will Johnson <[email protected]>
Signed-off-by: Will Johnson <[email protected]>
Signed-off-by: Will Johnson <[email protected]>
Signed-off-by: Will Johnson <[email protected]>
Signed-off-by: Will Johnson <[email protected]>
willmj
requested review from
Ssukriti,
aluu317,
anhuong,
fabianlim and
kmehant
as code owners
|
Thanks for making a pull request! 😃 |
kmehant
reviewed
Mar 20, 2025
| checkpoint(checkpoint_dir, self.save_model_dir) | ||
|
|
||
| callbacks.append( | ||
| ConvertAndSaveHFCheckpointAtEverySave( |
Collaborator
There was a problem hiding this comment.
Can we pass save_model_dir here and pick it up in __init__ ?
kmehant
reviewed
Mar 20, 2025
Collaborator
kmehant
left a comment
kmehant
left a comment
There was a problem hiding this comment.
@willmj apart from one comment I have, rest all looks good to me. Can you also confirm if you are able to pass both the unit tests for this feature on your end? Since I dont think these would run in our GitHub Action runners.
Signed-off-by: Will Johnson <[email protected]>
Signed-off-by: Will Johnson <[email protected]>
Signed-off-by: Will Johnson <[email protected]>
Signed-off-by: Will Johnson <[email protected]>
kmehant
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Building on PR #486, saving
hf_converted_checkpointtosave_model_dirif it exists.Was the PR tested