fix: fastmoe lora all-linear excluding router
#545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Will Johnson <[email protected]>
Signed-off-by: Will Johnson <[email protected]>
Signed-off-by: Will Johnson <[email protected]>
willmj
requested review from
aluu317,
anhuong,
dushyantbehl,
fabianlim and
kmehant
as code owners
|
Thanks for making a pull request! 😃 |
Signed-off-by: Will Johnson <[email protected]>
willmj
force-pushed
the
fix-fastmoe-lora-all-linear
branch
from
fb21e7b to
789eb60
Compare
willmj
changed the title
all-linear using exclude_modulesall-linear excluding router
Signed-off-by: Will Johnson <[email protected]>
Signed-off-by: Will Johnson <[email protected]>
anhuong
approved these changes
Apr 30, 2025
Collaborator
anhuong
left a comment
anhuong
left a comment
There was a problem hiding this comment.
LGTM, allowing all-linear now but depends on this PR foundation-model-stack/fms-acceleration#142 being merged first
dushyantbehl
pushed a commit
to dushyantbehl/fms-hf-tuning
that referenced
this pull request
Jun 23, 2025
…tack#545) * fix: all-linear passed through CLI Signed-off-by: Will Johnson <[email protected]> * fmt Signed-off-by: Will Johnson <[email protected]> * fix: exclude router module Signed-off-by: Will Johnson <[email protected]> * don't exclude Signed-off-by: Will Johnson <[email protected]> * warning update Signed-off-by: Will Johnson <[email protected]> * fix: more specific warning Signed-off-by: Will Johnson <[email protected]> --------- Signed-off-by: Will Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Goes with #142 to allow
all-linearfor ScatterMoE. Without the fms-acceleration PR to filter it out, router was included since it is a linear layer, but will not be able to run vLLM inference if it is included. With the fms-acceleration PR,all-linearcan be passed becauserouterwill always be filtered outRelated issue number
How to verify the PR
Was the PR tested