fix: Rollback trl to a version which doesn't overwrite labels and attention masks.#600
Closed
dushyantbehl wants to merge 1 commit intofoundation-model-stack:mainfrom
Closed
fix: Rollback trl to a version which doesn't overwrite labels and attention masks.#600dushyantbehl wants to merge 1 commit intofoundation-model-stack:mainfrom
dushyantbehl wants to merge 1 commit intofoundation-model-stack:mainfrom
Conversation
dushyantbehl
requested review from
aluu317,
anhuong,
fabianlim and
kmehant
as code owners
|
Thanks for making a pull request! 😃 |
dushyantbehl
requested review from
ashokponkumar
and removed request for
aluu317,
anhuong,
fabianlim and
kmehant
|
Thanks for making a pull request! 😃 |
Signed-off-by: Dushyant Behl <dushyantbehl@in.ibm.com>
dushyantbehl
force-pushed
the
rollback-trl
branch
from
0dc40b3 to
d335b51
Compare
dushyantbehl
added
the
on hold
| "tokenizers>=0.13.3,<1.0", | ||
| "tqdm>=4.66.2,<5.0", | ||
| "trl>=0.13,<0.18", | ||
| "trl>=0.13,<0.17", |
Collaborator
There was a problem hiding this comment.
If we are anyway returning the right collator, should we still revert the version?
Collaborator
Author
There was a problem hiding this comment.
This is on hold for now while I figure out the workaround but it was done because the collator seq2seq has some problems with v0.17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR rolbacks trl to v16.1 to solve https://github.ibm.com/ai-foundation/watson-fm-stack-tracker/issues/1913
Related issue number
How to verify the PR
Was the PR tested