fix: add default optim arg in training arg #607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yashasvi <[email protected]>
|
Thanks for making a pull request! 😃 |
YashasviChaurasia
requested review from
aluu317,
anhuong,
dushyantbehl,
fabianlim and
kmehant
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
The change defaults the optimizer argument to
adamw_torchas default for fms-hf-tuning.The default for hf trainer is
adamw_torch_fusedwhich wont be compatible with mixed precision, given that we push for mixed precision ="bf16" for performance, I propose we should makeadamw_torchas default for our stack..hf optim
Related issue number
How to verify the PR