feat: Allow chat template to be specified via a path in data config. #615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yashasvi <[email protected]>
|
Thanks for making a pull request! 😃 |
YashasviChaurasia
requested review from
aluu317,
anhuong,
dushyantbehl,
fabianlim and
kmehant
as code owners
dushyantbehl
requested changes
Oct 6, 2025
YashasviChaurasia
force-pushed
the
chat_template_path
branch
from
230f6b3 to
50921ed
Compare
dushyantbehl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
HF Models now allow users to load chat template via separate chat_template.jinja file which is unlike the chat template inside tokenizer config file. This means users who launch experiments via fms-hf-tuning on models where they want to update chat template need to copy paste it to the data config.
The PR would add support for
chat_template_pathindata_config.yamlso users can specify path to chat_template.jinja.Fixes a few typos along the way.
Related issue number
How to verify the PR
Was the PR tested