-
Notifications
You must be signed in to change notification settings - Fork 65
feat: alora migration to peft #618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: alora migration to peft #618
Conversation
Signed-off-by: yashasvi <[email protected]>
|
Thanks for making a pull request! 😃 |
Signed-off-by: Yashasvi Chaurasia <[email protected]>
dushyantbehl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes.
06ad63a to
02fd50c
Compare
Signed-off-by: yashasvi <[email protected]>
02fd50c to
8795ccb
Compare
|
@dushyantbehl Currently moving the As now we use LoraConfig for both |
ashokponkumar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @YashasviChaurasia !
dushyantbehl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of the change
This PR updates the codebase to switch from the external
alorapackage to the native Activated LoRA (aLoRA) support that is now part of the Hugging Facepeftlibrary.Key changes:
aloraimports and wrappers.config_utils.pyto handle aLoRA fields viapeft.LoraConfig.alora_invocation_tokensfor validation and inference.run_inference.pyby removing custom aLoRA handling (now handled natively by PEFT).Related issue number
How to verify the PR
Was the PR tested