Change gh-action-pypi to v1.12.4#89
Closed
BrandonGroth wants to merge 1 commit intofoundation-model-stack:mainfrom
Closed
Change gh-action-pypi to v1.12.4#89BrandonGroth wants to merge 1 commit intofoundation-model-stack:mainfrom
BrandonGroth wants to merge 1 commit intofoundation-model-stack:mainfrom
Conversation
BrandonGroth
requested review from
andrea-fasoli,
chichun-charlie-liu,
kcirred,
nwang-ibm and
tharapalanivel
as code owners
BrandonGroth
changed the title
BrandonGroth
force-pushed
the
github_pypi
branch
from
24aa1a9 to
07c4559
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Changed the github action gh/gh-action-pypi-publish to v1.12.4. There appears to be a bug in the metadata in our current github action version (v1.12.2) that was resolved in v1.12.3. This was causing our automatic builds to not be published to pypi.
Versions for github actions are done by "@commit_hash" for safety. The commit hash changed is pointing to the version for 1.12.4: 76f52bc884231f62b9a034ebfe128415bbaabdfc
pypa/gh-action-pypi-publish@76f52bc
How to verify the PR
I can't test the PR locally. We will have to see how it works in CI/CD.