feat: int8 granite addon#92
Merged
chichun-charlie-liu merged 2 commits intofoundation-model-stack:mainfrom Apr 9, 2025
Merged
Conversation
Signed-off-by: Andrea Fasoli <andrea.fasoli@ibm.com>
Collaborator
There was a problem hiding this comment.
is it required for AIU to make a "no bias" Linear layer into a Linear with bias (whose value is torch.zeros(1) )?
Collaborator
Author
There was a problem hiding this comment.
It's required by the AIU in the sense that the custom op always expects a tensor as bias (not None nor a bool).
We could change W8A8Linear forward
such that if self.bias does not exist we can create a zero tensor on the fly, cast it to the right device, and pass it to the op. I thought it'd be a more impactful overhead than just instantiating it once.
Collaborator
There was a problem hiding this comment.
just want to make sure it's a requirement from downstream stack. 8)
chichun-charlie-liu
approved these changes
Apr 9, 2025
50b6ce3
into
foundation-model-stack:main
11 checks passed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Was the PR tested