chore: sriov validation

[minmzzhang]

• kind/chore

What this PR does / why we need it:

• Add the template variable of SriovCniVersion instead of hardcoded "0.3.1"
• Add unit tests for rendering SR-IOV configuration
• Update SR-IOV NAD rendering from multi-nic-cni network args

Which issue(s) this PR is related to:

Closes #213, closes #233

When the multi-nic-cni for SR-IOV (multinic-sriov) firstly created, it had the correct info passed through from the definition:

apiVersion: multinic.fms.io/v1
kind: MultiNicNetwork
metadata:
  name: multinic-sriov
spec:
  subnet: "172.34.0.0/16"
  ipam: |
    {
      "type": "multi-nic-ipam",
      "hostBlock": 8,
      "interfaceBlock": 2,
      "vlanMode": "l2"
    }
  multiNICIPAM: true
  plugin:
    cniVersion: "1.0.0"
    type: sriov
    args:
      vlan: "1134"
      numVfs: "2"
      isRdma: "true"

spec:
  config: '{"cniVersion":"0.3.0","name":"multinic-sriov","type":"multi-nic","ipam":{"hostBlock":8,"interfaceBlock":2,"type":"multi-nic-ipam","vlanMode":"l2"},"dns":{},"plugin":{"cniVersion":"1.0.0","type":"sriov","vlan":1134},"subnet":"172.34.0.0/16","masterNets":["172.12.0.0/16"],"multiNICIPAM":true,"daemonIP":"","daemonPort":11000}'

However, after a while, the NAD get updated again, but with incorrect vlan info:

spec:
  config: '{"cniVersion":"0.3.0","name":"multinic-sriov","type":"multi-nic","ipam":{"hostBlock":8,"interfaceBlock":2,"type":"multi-nic-ipam","vlanMode":"l2"},"dns":{},"plugin":{"cniVersion":"1.0.0","type":"sriov","vlan":0},"subnet":"172.34.0.0/16","masterNets":["172.12.0.0/16"],"multiNICIPAM":true,"daemonIP":"","daemonPort":11000}'

This is due to the reconcile loop invoked by controller which impacts the SR-IOV plugin configuration. On the first call, SR-IOV plugin generates the correct config with a nested plugin object: "plugin":{"cniVersion":"1.0.0","type":"sriov","vlan":1134}. Then "RemoveEmpty" applied and the "plugin" field got stripped out becaues it is not in "netConfKeys"

var netConfKeys []string = []string{"cniVersion", "type"}

When the second reconcile call kicked in, the controller tries to update the NAD because CheckDefChanged detects the config difference, which resulted in a malformed config that breaks the plugin.

[sunya-ch]

LGTM!
Thank you so much. Wonderful work!

Additionally, I think we need to add doc about compatible version for each CNI too.

Created a follow-up issue to track here:

• #318