Skip to content

Conversation

@sunya-ch
Copy link
Collaborator

@sunya-ch sunya-ch commented Aug 14, 2025

  • kind/feat

What this PR does / why we need it:

cherry-pick:

Which issue(s) this PR is related to:

Based on

Need confirm whether the following change need from f5e0550#diff-1db7710d390d807a0392e69569890b934ca93f62774731d52653cdc7f9eb012d

@@ -396,6 +396,10 @@ func loadConf(args *skel.CmdArgs) (*NetConf, string, error) {
	}
	selectResponse, err := selectNICs(n.DaemonIP, n.DaemonPort, podName, podNamespace, hostName, n.Name, nicSet, n.MasterNetAddrs)
	if err != nil {
+		if n.IPAM.Type == MultiConfigIPAMType {
+			// allow to have empty Masters
+			err = nil
+		}
		return n, deviceType, err
	}
	n.Masters = selectResponse.Masters

@sunya-ch sunya-ch added this to the v1.3.1 milestone Aug 14, 2025
@sunya-ch sunya-ch added the kind/feat New feature or change present behavior label Aug 14, 2025
@sunya-ch sunya-ch marked this pull request as draft August 14, 2025 05:44
@sunya-ch sunya-ch changed the title Feat multi config feat: add multi-config and handle static ips Aug 14, 2025
@sunya-ch sunya-ch added area/cni CNI plugin related changes area/testing Test related changes area/ci CI/CD and workflow changes area/config labels Sep 2, 2025
@sunya-ch sunya-ch marked this pull request as ready for review September 2, 2025 09:32
@sunya-ch sunya-ch merged commit ece0634 into foundation-model-stack:main Sep 17, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci CI/CD and workflow changes area/cni CNI plugin related changes area/config area/testing Test related changes kind/feat New feature or change present behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant