Update base image #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mateus Devino <mdevino@ibm.com>
evaline-ju
reviewed
Jul 2, 2025
pyproject.toml
Outdated
| "pre-commit>=3.0.4,<4.0", | ||
| "pydeps>=1.12.12,<2", | ||
| ] | ||
| dev-fmt = ["ruff==0.4.7", "pre-commit>=3.0.4,<4.0", "pydeps>=1.12.12,<2"] |
Collaborator
There was a problem hiding this comment.
hm what formatting is this? I think the individual lines were easier to read
Contributor
Author
There was a problem hiding this comment.
I just have my editor to automatically format on save. Did we ever configure formatting for this repository?
Signed-off-by: Mateus Devino <mdevino@ibm.com>
Signed-off-by: Mateus Devino <mdevino@ibm.com>
Signed-off-by: Mateus Devino <mdevino@ibm.com>
Signed-off-by: Mateus Devino <mdevino@ibm.com>
evaline-ju
approved these changes
Jul 7, 2025
Collaborator
evaline-ju
left a comment
evaline-ju
left a comment
There was a problem hiding this comment.
generally LGTM with nit
Signed-off-by: Mateus Devino <mdevino@ibm.com>
evaline-ju
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #77.
Updates base image to
quay.io/modh/vllm:rhoai-2.23-cuda.