✨ Support Granite Guardian 3.3 criteria parameters #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evaline Ju <[email protected]>
Signed-off-by: Evaline Ju <[email protected]>
Signed-off-by: Evaline Ju <[email protected]>
evaline-ju
commented
Aug 6, 2025
| vllm-tgis-adapter = ["vllm-tgis-adapter>=0.7.0,<0.7.2"] | ||
| vllm = [ | ||
| # Note: 0.8.4 has a triton bug on Mac | ||
| "transformers<4.54.0", # vllm <= 0.10.0 has issues with higher transformers versions, fixed later in https://github.com/vllm-project/vllm/pull/20921 |
Collaborator
Author
There was a problem hiding this comment.
This fix isn't released yet so tests will fail with ValueError: 'aimv2' is already used by a Transformers config, pick another name. with the latest transformers versions
gkumbhat
reviewed
Aug 8, 2025
gkumbhat
approved these changes
Aug 8, 2025
Collaborator
gkumbhat
left a comment
gkumbhat
left a comment
There was a problem hiding this comment.
small nit, but otherwise, looks good
Signed-off-by: Evaline Ju <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Granite Guardian 3.3 ref now takes
criteria_idinstead ofrisk_nameas in previous generations/versions. Since users may still want to use the adapter with 3.2 while testing out 3.3, the new parameters have been added, without the old ones removed. It has been confirmed that the extra presence ofcriteria_iddoes not impact older models, nor does the presence ofrisk_nameimpact the 3.3 model, so the adapter does not specifically have to check versions.transformers pin needed due to
https://github.com/vllm-project/vllm-ascend/issues/2046Closes: #86