Update main.rs #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added in the gravity and falling of the blocks from a certain height
allsey87
requested changes
Nov 18, 2024
| commands | ||
| .spawn((Collider::cuboid(cube_size * 0.5, cube_size * 0.5, cube_size * 0.5), RigidBody::Dynamic)) | ||
| .insert(ColliderMassProperties::Mass(1.0)) | ||
| .insert(Damping { linear_damping: 0.1, angular_damping: 0.1 }) |
There was a problem hiding this comment.
Remove this, boxes of different masses should fall at the same acceleration and damping is (probably) not necessary for this project.
| commands | ||
| .spawn((Collider::cuboid(cube_size * 0.5, cube_size * 0.5, cube_size * 0.5), RigidBody::Dynamic)) | ||
| .insert(ColliderMassProperties::Mass(10.0)) | ||
| .insert(Damping { linear_damping: 0.02, angular_damping: 0.02 }) |
There was a problem hiding this comment.
Remove this, boxes of different masses should fall at the same acceleration and damping is (probably) not necessary for this project.
Comment on lines
-37
to
+40
| fn render_origin(mut gizmos: Gizmos) { | ||
| gizmos.line(Vec3::ZERO, Vec3::X, Color::RED); | ||
| gizmos.line(Vec3::ZERO, Vec3::Y, Color::GREEN); | ||
| gizmos.line(Vec3::ZERO, Vec3::Z, Color::BLUE); | ||
| } | ||
| // fn render_origin(mut gizmos: Gizmos) { | ||
| // gizmos.line(Vec3::ZERO, Vec3::X, Color::RED); | ||
| // gizmos.line(Vec3::ZERO, Vec3::Y, Color::GREEN); | ||
| // gizmos.line(Vec3::ZERO, Vec3::Z, Color::BLUE); | ||
| // } |
There was a problem hiding this comment.
Commenting code in and out like this results in noise in your commit messages and makes it harder for me to see what has changed. Commits should always contain as few changes as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added in the gravity and falling of the blocks from a certain height