fix: sanitize settings.optimizer.details.inliner
#216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
approved these changes
Nov 18, 2024
DaniPopes
requested changes
Nov 18, 2024
grandizzy
force-pushed
the
inliner-optimizer
branch
from
b54ed81 to
d348efb
Compare
grandizzy
force-pushed
the
inliner-optimizer
branch
from
d348efb to
59dc023
Compare
DaniPopes
approved these changes
Nov 18, 2024
DaniPopes
changed the title
None in with_via_ir_minimum_optimizationinliner config
DaniPopes
changed the title
inliner configoptimizer.details.inliner config
DaniPopes
changed the title
optimizer.details.inliner configsettings.optimizer.details config
DaniPopes
changed the title
settings.optimizer.details configsettings.optimizer.details.inliner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref foundry-rs/foundry#9322 (comment)
argotorg/solidity#15576 (comment)
Set inliner to None since it is properly supported from 0.8.5 version( see
Standard JSON: Properly allow the inliner setting under settings.optimizer.detailshttps://soliditylang.org/blog/2021/06/10/solidity-0.8.5-release-announcement/)