Skip to content

Bump solar version #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2025
Merged

Bump solar version #264

merged 2 commits into from
May 12, 2025

Conversation

@grandizzy
Copy link
Contributor

@grandizzy grandizzy commented May 10, 2025 •
edited
Loading

@grandizzy grandizzy marked this pull request as draft May 10, 2025 07:56
@grandizzy grandizzy marked this pull request as ready for review May 10, 2025 08:09
DaniPopes
DaniPopes reviewed May 10, 2025
View reviewed changes
.github/workflows/ci.yml
exclude:
# Skip because some features have higher MSRV.
- rust: "1.83" # MSRV
flags: "--all-features"
Copy link
Member

@DaniPopes DaniPopes May 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not right, you bump the msrv not remove the test that checks compatibility :D

Copy link
Contributor Author

@grandizzy grandizzy May 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫠

Copy link
Contributor Author

@grandizzy grandizzy May 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redone, pls check

@grandizzy grandizzy marked this pull request as draft May 10, 2025 09:14
@grandizzy grandizzy marked this pull request as ready for review May 10, 2025 09:22
@grandizzy grandizzy requested a review from DaniPopes May 10, 2025 09:22
mattsse
mattsse approved these changes May 10, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pending @DaniPopes

@DaniPopes
Copy link
Member

DaniPopes commented May 10, 2025 •
edited
Loading

this breaks the msrv policy but whatever, it should just be latest msrv

@zerosnacks zerosnacks mentioned this pull request May 12, 2025
Closed
@zerosnacks zerosnacks self-requested a review May 12, 2025 08:49
zerosnacks
zerosnacks approved these changes May 12, 2025
View reviewed changes
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

This was referenced May 12, 2025
Merged
Closed
@mattsse mattsse merged commit 96d6ad9 into foundry-rs:main May 12, 2025
15 checks passed
@grandizzy grandizzy deleted the bump-solar branch May 12, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes DaniPopes approved these changes

@zerosnacks zerosnacks zerosnacks approved these changes

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@grandizzy @DaniPopes @mattsse @zerosnacks