fix: is_dirty to use additional_files #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grandizzy
changed the title
mattsse
requested changes
May 16, 2025
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
I think this makes sense but the extra ! is a bit confusing, can we add a note here?
crates/compilers/src/cache.rs
Outdated
| for artifacts in artifacts.values() { | ||
| for artifact_file in artifacts { | ||
| if self.project.artifacts_handler().is_dirty(artifact_file).unwrap_or(true) { | ||
| if !artifact_file.file.starts_with(&self.project.paths.artifacts) |
Member
There was a problem hiding this comment.
what's an example for an artifact_file that doesn't reside in the artifacts folder?
Contributor
Author
There was a problem hiding this comment.
thanks for pushing back, I got this totally wrong. the reason here is that we have additional_values and additional_files and we didn't account the additional files when checking if artifact dirty in cache, changed with abb1371
grandizzy
changed the title
mattsse
approved these changes
May 16, 2025
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
ah this makes a lot of sense now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/home/george/work/foundry-issues/issue-preproc/out/Base.sol/CommonBase.jsonare checked and erroneously flag missing extra files / rebuild sources