Add missing nodetypes on serialize/deserialize statement #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yeah, I think this one went rouge lol undoing this because adding dedicated variants is better long term |
mattsse
added a commit
that referenced
this pull request
Jun 14, 2025
Member
|
closing this because reverted the manual serde impl #284 tuned the perms hehe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this issue #280 two changes were added. One to add the new types #282 and another one to add custom deserialise functions (it looks to me committed to main directly?
But the second one was added without rebasing the first change so the match statement for the node types fails to account for the new types.
Note that this also breaks the version 0.17.2