Skip to content

Fix typos in comments and variable names across solc-related modules #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2025
Merged

Fix typos in comments and variable names across solc-related modules #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7436b53
Update output_selection.rs
GarmashAlex Jun 23, 2025
941dd50
Update compiler.rs
GarmashAlex Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/artifacts/solc/src/output_selection.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ impl ContractOutputSelection {
/// that solc emits.
///
/// These correspond to the fields in `CompactBytecode`, `CompactDeployedBytecode`, ABI, and
/// method identfiers.
/// method identifiers.
pub fn basic() -> Vec<Self> {
// We don't include all the `bytecode` fields because `generatedSources` is a massive JSON
// object and is not used by Foundry.
Expand Down Expand Up @@ -610,7 +610,7 @@ mod tests {
assert!(!output_selection.is_subset_of(&output_selection_empty));
assert!(!output_selection_abi.is_subset_of(&output_selection_empty));

let output_selecttion_specific = OutputSelection::from(BTreeMap::from([(
let output_selection_specific = OutputSelection::from(BTreeMap::from([(
"Contract.sol".to_string(),
BTreeMap::from([(
"Contract".to_string(),
Expand All @@ -622,7 +622,7 @@ mod tests {
)]),
)]));

assert!(!output_selecttion_specific.is_subset_of(&output_selection));
assert!(!output_selection_specific.is_subset_of(&output_selection));
}

#[test]
Expand Down
4 changes: 2 additions & 2 deletions crates/compilers/src/compilers/solc/compiler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ impl Solc {

trace!("blocking installing solc version \"{}\"", version);
crate::report::solc_installation_start(&version);
// The async version `svm::install` is used instead of `svm::blocking_intsall`
// The async version `svm::install` is used instead of `svm::blocking_install`
// because the underlying `reqwest::blocking::Client` does not behave well
// inside of a Tokio runtime. See: https://github.com/seanmonstar/reqwest/issues/1017
match RuntimeOrHandle::new().block_on(svm::install(&version)) {
Expand Down Expand Up @@ -475,7 +475,7 @@ impl Solc {
move |err| SolcError::io(err, &self.solc)
}

/// Configures [Command] object depeending on settings and solc version used.
/// Configures [Command] object depending on settings and solc version used.
/// Some features are only supported by newer versions of solc, so we have to disable them for
/// older ones.
pub fn configure_cmd(&self) -> Command {
Expand Down
Loading