feat: add SourceParser
#300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
requested review from
0xrusowsky,
grandizzy,
klkvr,
mattsse,
onbjerg,
yash-atreya and
zerosnacks
as code owners
0xrusowsky
approved these changes
Aug 21, 2025
Comment on lines
397
to
403
| // Set error on the first source if any. This doesn't really have to be exact, as long | ||
| // as at least one source has an error set it should be enough. | ||
| if let Some(Err(diag)) = compiler.gcx().sess.emitted_errors() { | ||
| if let Some(first) = parsed.first_mut() { | ||
| first.1.data.parse_result = Err(diag.to_string()); | ||
| } | ||
| } |
There was a problem hiding this comment.
should we open a solar issue to expose a way to map diagnostics back to their source files? maybe something like one of these options?
- a method to query diagnostics emitted by a given file
compiler.gcx().sess.emitted_errors_by(path) - a more generic method
compiler.gcx().sess.emitted_errors_by_source()that returns a map of paths to their diagnostics
There was a problem hiding this comment.
I don't think this is very useful in practice, we don't store this information
zerosnacks
reviewed
Aug 21, 2025
DaniPopes
added a commit
to paradigmxyz/solar
that referenced
this pull request
Aug 22, 2025
Introduce `solar_sema::Compiler`. This is a unified API for the full compiler pipeline, as well as encapsulating the `enter(|| _)` requirement by only allowing access to the context when inside of the closure. See the HIR example and tests for the usage diff. Migrations: - foundry-compilers foundry-rs/compilers#300 - foundry: foundry-rs/foundry#11371 Closes #370.
onbjerg
approved these changes
Aug 22, 2025
|
|
||
| #[derive(Clone, Debug, Default)] | ||
| pub struct VyperParser { | ||
| _inner: (), |
Co-authored-by: onbjerg <[email protected]>
DaniPopes
force-pushed
the
dani/parsed-sources
branch
from
1bd726e to
f1413c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows persisting a shared
solar_sema::Compilerthroughout compilation and storing it inside of the output.