Skip to content

fix(flatten): sort by loc path and loc start #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2025
Merged

fix(flatten): sort by loc path and loc start #302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/compilers/src/flatten.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,10 +317,10 @@ impl Flattener {
// `loc.path` is expected to be different for each id because there can't be 2
// top-level declarations with the same name in the same file.
//
// Sorting by index loc.path in sorted files to make the renaming process
// deterministic.
// Sorting by index loc.path and loc.start in sorted files to make the renaming
// process deterministic.
ids.sort_by_key(|(_, loc)| {
self.ordered_sources.iter().position(|p| p == &loc.path).unwrap()
(self.ordered_sources.iter().position(|p| p == &loc.path).unwrap(), loc.start)
});
}
for (i, (id, loc)) in ids.iter().enumerate() {
Expand Down
Loading