fix: make sources' paths absolute #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cache entries are keyed by absolute path relative to project root, but it's possible to construct and pass in Sources from a relative path, such as CLI argument in `forge lint`/`forge eip712`... In these cases the path will be relative and will always be a cache miss. This includes the path's imports, which get resolved as relative to the initial path rather than root now with Solar. Make all paths in Sources absolute when constructing Graph so that this change propagates through the entire compilation process. I couldn't find a reproducer in today's stable/nightly Foundry, however making `config.solar_project()` use `project()` instead of `ephemeral_project()` will reproduce the behavior explained above. With this change, `solar_project` will almost never call to solc.
DaniPopes
requested review from
0xrusowsky,
grandizzy,
klkvr,
mattsse,
onbjerg,
yash-atreya and
zerosnacks
as code owners
mattsse
approved these changes
Aug 29, 2025
Comment on lines
+403
to
+404
| // The cache relies on the absolute paths relative to the project root as cache keys. | ||
| sources.make_absolute(&paths.root); |
There was a problem hiding this comment.
ah I believe that makes sense
can't think of any issues this cause
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache entries are keyed by absolute path relative to project root, but it's possible to construct and pass in Sources from a relative path, such as CLI argument in
forge lint/forge eip712...In these cases the path will be relative and will always be a cache miss. This includes the path's imports, which get resolved as relative to the initial path rather than root now with Solar.
Make all paths in Sources absolute when constructing Graph so that this change propagates through the entire compilation process.
I couldn't find a reproducer in today's stable/nightly Foundry, however making
config.solar_project()useproject()instead ofephemeral_project()will reproduce the behavior explained above.With this change,
solar_projectwill almost never call to solc.