Skip to content

chore(ci): harden workflow by setting default permission to read only #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zerosnacks merged 4 commits into from
Sep 15, 2025
Merged

chore(ci): harden workflow by setting default permission to read only #320

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a50c00d
scope permissions, cache requires write
zerosnacks Sep 15, 2025
c8faee4
use nightly clippy in line with other foundry crates
zerosnacks Sep 15, 2025
8ea804c
drop write permissions, not necessary
zerosnacks Sep 15, 2025
ee7d996
Merge branch 'main' into zerosnacks/harden-ci
zerosnacks Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
name: CI

permissions:
contents: read

on:
push:
branches: [main]
Expand All @@ -18,6 +21,8 @@ jobs:
name: test ${{ matrix.rust }} ${{ matrix.flags }} (${{ matrix.os }})
runs-on: ${{ matrix.os }}
timeout-minutes: 30
permissions:
actions: write
strategy:
fail-fast: false
matrix:
Expand All @@ -30,6 +35,8 @@ jobs:
flags: "--all-features"
steps:
- uses: actions/checkout@v5
with:
persist-credentials: false
- uses: dtolnay/rust-toolchain@master
with:
toolchain: ${{ matrix.rust }}
Expand All @@ -48,8 +55,12 @@ jobs:
doctest:
runs-on: ubuntu-latest
timeout-minutes: 30
permissions:
actions: write
steps:
- uses: actions/checkout@v5
with:
persist-credentials: false
- uses: dtolnay/rust-toolchain@stable
- uses: Swatinem/rust-cache@v2
with:
Expand All @@ -59,8 +70,12 @@ jobs:
feature-checks:
runs-on: ubuntu-latest
timeout-minutes: 30
permissions:
actions: write
steps:
- uses: actions/checkout@v5
with:
persist-credentials: false
- uses: dtolnay/rust-toolchain@stable
- uses: taiki-e/install-action@cargo-hack
- uses: Swatinem/rust-cache@v2
Expand All @@ -72,11 +87,13 @@ jobs:
clippy:
runs-on: ubuntu-latest
timeout-minutes: 30
permissions:
actions: write
steps:
- uses: actions/checkout@v5
- uses: dtolnay/rust-toolchain@stable
with:
components: clippy
persist-credentials: false
- uses: dtolnay/rust-toolchain@clippy
Comment on lines +87 to +88
Copy link
Member Author

@zerosnacks zerosnacks Sep 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: this now uses @clippy in line with other Foundry crates & Foundry which is nightly + clippy shorthand

- uses: Swatinem/rust-cache@v2
with:
cache-on-failure: true
Expand All @@ -87,8 +104,12 @@ jobs:
docs:
runs-on: ubuntu-latest
timeout-minutes: 30
permissions:
actions: write
steps:
- uses: actions/checkout@v5
with:
persist-credentials: false
- uses: dtolnay/rust-toolchain@nightly
- uses: Swatinem/rust-cache@v2
with:
Expand All @@ -102,6 +123,8 @@ jobs:
timeout-minutes: 30
steps:
- uses: actions/checkout@v5
with:
persist-credentials: false
- uses: dtolnay/rust-toolchain@nightly
with:
components: rustfmt
Expand All @@ -113,6 +136,7 @@ jobs:
ci-success:
runs-on: ubuntu-latest
if: always()
permissions: {}
needs:
- test
- doctest
Expand Down
Loading