OP Networks Add

[ElliotFriedman]

Add: zora, race, metal, binary, orderly and mode testnets and mainnet configs.

[mds1]

Hey @zerosnacks @grandizzy, looks like the foundryup changes broke CI here—could you PR in a fix?

edit: I read to fast and the foundryup change is just a warning, the actual CI failure is stack too deep

[ElliotFriedman]

I was able to replicate this locally, however I backed my changes out locally and the issue still appeared, which tells me this is likely an issue that popped up within the latest foundry release.

None of this code adds new stack variables that would cause the stack too deep issue.

[ElliotFriedman]

I could not replicate this issue on my machine until I updated foundry, then I was able to reproduce, which points to this issue stemming from the latest foundry release.

[grandizzy]

yeah, we probably have to add optimizer = true and optimizer_runs = 200 in foundry.toml to keep same setup

[ElliotFriedman]

yeah, we probably have to add optimizer = true and optimizer_runs = 200 in foundry.toml to keep same setup

Done, that seems to fix the problem, at least locally.

It's hard to understand what downstream effects this will have if any of users of the library.

Would this force compile of tests in downstream repos with these optimizer settings?

[grandizzy]

yeah, we probably have to add optimizer = true and optimizer_runs = 200 in foundry.toml to keep same setup

Done, that seems to fix the problem, at least locally.

It's hard to understand what downstream effects this will have if any of users of the library.

Would this force compile of tests in downstream repos with these optimizer settings?

That's correct. This was the default in foundry until foundry-rs/foundry#9657 which disables optimizer by default, so I don't think there'll be any issue.

[zerosnacks]

Thanks @ElliotFriedman!