Skip to content

chore(StdAssertions): manually invert conditions #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaniPopes merged 1 commit into from
Jul 31, 2025
Merged

chore(StdAssertions): manually invert conditions #699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions src/StdAssertions.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,13 +402,13 @@ abstract contract StdAssertions {
}

function assertLt(uint256 left, uint256 right) internal pure virtual {
if (!(left < right)) {
if (left >= right) {
Copy link
Contributor

@0xrusowsky 0xrusowsky Jul 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this case i think both take 2 opcodes, but personally i prefer this one for clarity. nice!

vm.assertLt(left, right);
}
}

function assertLt(uint256 left, uint256 right, string memory err) internal pure virtual {
if (!(left < right)) {
if (left >= right) {
vm.assertLt(left, right, err);
}
}
Expand All @@ -422,13 +422,13 @@ abstract contract StdAssertions {
}

function assertLt(int256 left, int256 right) internal pure virtual {
if (!(left < right)) {
if (left >= right) {
vm.assertLt(left, right);
}
}

function assertLt(int256 left, int256 right, string memory err) internal pure virtual {
if (!(left < right)) {
if (left >= right) {
vm.assertLt(left, right, err);
}
}
Expand All @@ -442,13 +442,13 @@ abstract contract StdAssertions {
}

function assertGt(uint256 left, uint256 right) internal pure virtual {
if (!(left > right)) {
if (left <= right) {
vm.assertGt(left, right);
}
}

function assertGt(uint256 left, uint256 right, string memory err) internal pure virtual {
if (!(left > right)) {
if (left <= right) {
vm.assertGt(left, right, err);
}
}
Expand All @@ -462,13 +462,13 @@ abstract contract StdAssertions {
}

function assertGt(int256 left, int256 right) internal pure virtual {
if (!(left > right)) {
if (left <= right) {
vm.assertGt(left, right);
}
}

function assertGt(int256 left, int256 right, string memory err) internal pure virtual {
if (!(left > right)) {
if (left <= right) {
vm.assertGt(left, right, err);
}
}
Expand All @@ -482,13 +482,13 @@ abstract contract StdAssertions {
}

function assertLe(uint256 left, uint256 right) internal pure virtual {
if (!(left <= right)) {
if (left > right) {
vm.assertLe(left, right);
}
}

function assertLe(uint256 left, uint256 right, string memory err) internal pure virtual {
if (!(left <= right)) {
if (left > right) {
vm.assertLe(left, right, err);
}
}
Expand All @@ -502,13 +502,13 @@ abstract contract StdAssertions {
}

function assertLe(int256 left, int256 right) internal pure virtual {
if (!(left <= right)) {
if (left > right) {
vm.assertLe(left, right);
}
}

function assertLe(int256 left, int256 right, string memory err) internal pure virtual {
if (!(left <= right)) {
if (left > right) {
vm.assertLe(left, right, err);
}
}
Expand All @@ -522,13 +522,13 @@ abstract contract StdAssertions {
}

function assertGe(uint256 left, uint256 right) internal pure virtual {
if (!(left >= right)) {
if (left < right) {
vm.assertGe(left, right);
}
}

function assertGe(uint256 left, uint256 right, string memory err) internal pure virtual {
if (!(left >= right)) {
if (left < right) {
vm.assertGe(left, right, err);
}
}
Expand All @@ -542,13 +542,13 @@ abstract contract StdAssertions {
}

function assertGe(int256 left, int256 right) internal pure virtual {
if (!(left >= right)) {
if (left < right) {
vm.assertGe(left, right);
}
}

function assertGe(int256 left, int256 right, string memory err) internal pure virtual {
if (!(left >= right)) {
if (left < right) {
vm.assertGe(left, right, err);
}
}
Expand Down