Skip to content

Add zero-division checks to stdMath.percentDelta overloads #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+6 −2
Open

Add zero-division checks to stdMath.percentDelta overloads #735

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0654ae4
Update StdMath.sol
viktorking7 Sep 23, 2025
7cdb068
Merge branch 'master' into master
zerosnacks Oct 6, 2025
f29fa19
Apply suggestions from code review
zerosnacks Oct 6, 2025
494ec84
fix test
zerosnacks Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/StdMath.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ library stdMath {
}

function percentDelta(uint256 a, uint256 b) internal pure returns (uint256) {
// Prevent division by zero
require(b != 0, "stdMath: percentDelta divisor is zero");
uint256 absDelta = delta(a, b);

return absDelta * 1e18 / b;
Expand All @@ -37,6 +39,8 @@ library stdMath {
function percentDelta(int256 a, int256 b) internal pure returns (uint256) {
uint256 absDelta = delta(a, b);
uint256 absB = abs(b);
// Prevent division by zero
require(absB != 0, "stdMath: percentDelta divisor is zero");

return absDelta * 1e18 / absB;
}
Expand Down