Skip to content

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Mar 10, 2025

Motivation

Bumps revm to latest version. I've removed CfgEnv from BlockchainDbMeta as it seems unused and it's now generic over SpecId which we ideally don't need to deal with on fork-db lavel.

Solution

PR Checklist

  • Fixed Tests
  • Added Documentation
  • Breaking changes

@klkvr klkvr mentioned this pull request Mar 10, 2025
3 tasks
@zerosnacks zerosnacks marked this pull request as ready for review March 20, 2025 11:30
@zerosnacks
Copy link
Member

Marked this as ready for review, please move back to draft @klkvr if this is incorrect

@jenpaff jenpaff added this to Foundry Apr 15, 2025
@jenpaff jenpaff moved this to Ready For Review in Foundry Apr 15, 2025
@jenpaff jenpaff moved this from Ready For Review to In Progress in Foundry Apr 15, 2025
@jenpaff jenpaff moved this from In Progress to Blocked in Foundry Apr 23, 2025
@jenpaff
Copy link

jenpaff commented Apr 23, 2025

@zerosnacks can you confirm that this will only be merged once we're done with #44 ?

@zerosnacks
Copy link
Member

It likely makes sense to merge once #44 is in a mergeable state as that will test the changes

That said, the scope is minimal enough that is could be merged prior if it is a blocker for anything

@jenpaff
Copy link

jenpaff commented Apr 24, 2025

It likely makes sense to merge once #44 is in a mergeable state as that will test the changes

That said, the scope is minimal enough that is could be merged prior if it is a blocker for anything

Not blocking, just wanted to get an idea since it was open & approved for a while now. Marking as blocked & we can decide when to merge

@yash-atreya yash-atreya mentioned this pull request May 7, 2025
3 tasks
@zerosnacks zerosnacks self-requested a review May 7, 2025 14:34
@zerosnacks zerosnacks marked this pull request as draft May 7, 2025 14:41
@zerosnacks zerosnacks changed the title feat: bump revm feat: bump revm to 21.0.0 May 7, 2025
@zerosnacks zerosnacks changed the title feat: bump revm to 21.0.0 feat: bump revm to 21.0.0 and alloy to 0.13.0 May 7, 2025
@zerosnacks zerosnacks marked this pull request as ready for review May 7, 2025 14:45
"difficulty": "0x0",
"basefee": "0x2e5fda223",
"gas_limit": "0x1c9c380",
"basefee": 12448539171,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, didn't realize we have this serde breaking change. @rakita @mattsse should we fix it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or I guess this shouldn't really affect anything

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm this is a change from U256 to u128 fields. I didn't get any complaints on this part, would say it is fine to leave as is

@klkvr klkvr force-pushed the klkvr/bump-revm branch from cfbf178 to b0dda45 Compare May 7, 2025 15:00
@klkvr klkvr force-pushed the klkvr/bump-revm branch from b0dda45 to 0da5d63 Compare May 7, 2025 15:02
@klkvr klkvr merged commit 811a61a into main May 7, 2025
15 checks passed
@klkvr klkvr deleted the klkvr/bump-revm branch May 7, 2025 15:08
@github-project-automation github-project-automation bot moved this from Blocked to Done in Foundry May 7, 2025
@grandizzy grandizzy moved this from Done to Completed in Foundry May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Completed

Development

Successfully merging this pull request may close these issues.

7 participants