-
Notifications
You must be signed in to change notification settings - Fork 19
feat: bump revm to 21.0.0
and alloy to 0.13.0
#44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Marked this as ready for review, please move back to draft @klkvr if this is incorrect |
@zerosnacks can you confirm that this will only be merged once we're done with #44 ? |
It likely makes sense to merge once #44 is in a mergeable state as that will test the changes That said, the scope is minimal enough that is could be merged prior if it is a blocker for anything |
Not blocking, just wanted to get an idea since it was open & approved for a while now. Marking as blocked & we can decide when to merge |
21.0.0
21.0.0
and alloy to 0.13.0
"difficulty": "0x0", | ||
"basefee": "0x2e5fda223", | ||
"gas_limit": "0x1c9c380", | ||
"basefee": 12448539171, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or I guess this shouldn't really affect anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm this is a change from U256 to u128 fields. I didn't get any complaints on this part, would say it is fine to leave as is
Motivation
Bumps revm to latest version. I've removed
CfgEnv
fromBlockchainDbMeta
as it seems unused and it's now generic overSpecId
which we ideally don't need to deal with on fork-db lavel.Solution
PR Checklist