perf: clone for serializing #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
approved these changes
Jun 13, 2025
|
Ref foundry-rs/foundry#10452, possible solution |
DaniPopes
approved these changes
Jun 13, 2025
onbjerg
added a commit
to ithacaxyz/relay
that referenced
this pull request
Jun 13, 2025
Fixes a flaky tx service test and adds `--no-storage-caching` which temporarily solves the deadlock issue when fetching storage slots, closing #792. This might be the same issue as foundry-rs/foundry#10452 and could potentially be solved when foundry-rs/foundry-fork-db#51 lands in Foundry
3 tasks
yongkangc
pushed a commit
to ithacaxyz/relay
that referenced
this pull request
Aug 5, 2025
Fixes a flaky tx service test and adds `--no-storage-caching` which temporarily solves the deadlock issue when fetching storage slots, closing #792. This might be the same issue as foundry-rs/foundry#10452 and could potentially be solved when foundry-rs/foundry-fork-db#51 lands in Foundry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we're holding the lock for the entire serialize call which is more expensive than cloning the data first, so we should clone so that we can drop the readlock immediately.
if this is serialized into a file directly via bufwriter this could cause issues