Skip to content

Conversation

0xferrous
Copy link
Contributor

@0xferrous 0xferrous commented Jul 29, 2025

Motivation

Sometimes huge method identifiers(usually because of big structs as arguments) make the table unreadable without wrapping. Wrapping can help with that.

Solution

Add an option --wrap/-w to enable wrapping of content to fit the table width to terminal width. This is a non breaking change since by default it is still unwrapped.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@0xferrous 0xferrous marked this pull request as ready for review July 29, 2025 07:16
Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, I think this makes sense - CC @zerosnacks pls share your thoughts
Mind to add an unit test too?

@0xferrous 0xferrous marked this pull request as draft July 30, 2025 09:53
@0xferrous
Copy link
Contributor Author

I looked into adding test for this, but we'd have to run the command via a tty where we can set the terminal width, etc. Is that the way you want to go? @grandizzy

@grandizzy
Copy link
Collaborator

I looked into adding test for this, but we'd have to run the command via a tty where we can set the terminal width, etc. Is that the way you want to go? @grandizzy

Ah, if complex

I looked into adding test for this, but we'd have to run the command via a tty where we can set the terminal width, etc. Is that the way you want to go? @grandizzy

ah, if complex lile this then we could just skip it

@0xferrous 0xferrous force-pushed the feat/comfy-table-wrapping branch from 791381d to 7197ad4 Compare August 9, 2025 08:07
@0xferrous
Copy link
Contributor Author

0xferrous commented Aug 9, 2025

tasked claude with it, TIL there is a script command that starts a tty

@0xferrous 0xferrous marked this pull request as ready for review August 9, 2025 09:00
@0xferrous
Copy link
Contributor Author

can someone run the failed job again, its an unrelated failure

@0xferrous 0xferrous requested a review from zerosnacks August 20, 2025 07:56
@zerosnacks zerosnacks dismissed their stale review August 26, 2025 11:57

outdated

@zerosnacks
Copy link
Member

zerosnacks commented Aug 26, 2025

small nit, other than that lgtm 👍! Thanks

@zerosnacks zerosnacks self-requested a review August 26, 2025 12:08
@zerosnacks
Copy link
Member

zerosnacks commented Aug 26, 2025

Pending re-review of @grandizzy

re: unit test, see #11138 (comment)

I didn't feel it made sense to pull in a new dependency to test this highly specific case

Manually tested, works well

Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@zerosnacks zerosnacks merged commit 4e59f42 into foundry-rs:master Aug 26, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Aug 26, 2025
@0xferrous 0xferrous deleted the feat/comfy-table-wrapping branch August 26, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants