v1.3.1 backports #11207
Merged
v1.3.1 backports #11207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(cast): use all providers if local artifacts used * Fix
…idation (foundry-rs#11111) * fix(mktx): improve handling of `--raw-unsigned` with runtime validation - Updated the logic for handling the `--from` argument in the `run` function. - Added validation for required `nonce` parameter when `--from` is not provided, ensuring necessary transaction details are specified. - Used `Address::ZERO` as a placeholder when there is no need to query provider - unit tests * fix: fmt
* fix(forge): consistent handling unresolved imports * Add test
* Bump compilers 0.18.2 * Add test
foundry-rs#11194) * fix(forge): improve error messages for etherscan verification failures * fix: cargo clippy * tests(forge): add tests for unknown chain id * fix: err formating for EtherscanConfigError --------- Co-authored-by: zerosnacks <[email protected]>
* chore: bump forge-std version used for tests * Fixes --------- Co-authored-by: DaniPopes <[email protected]> Co-authored-by: grandizzy <[email protected]>
grandizzy
requested review from
DaniPopes,
klkvr,
mattsse,
yash-atreya and
zerosnacks
as code owners
mattsse
approved these changes
Aug 5, 2025
zerosnacks
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes:
cast):--with-local-artifactsfails with libraries if remappings missing from foundry.toml #11084 (fix(cast): use all providers if local artifacts used #11090)fromparameter is required #11110 (fix(cast): improve handling ofmktx --raw-unsignedwith runtime validation #11111)anvil): unwrap panic ineth/backend/mem/mod.rs#11128 (fix(anvil): unwrap panic ineth/backend/mem/mod.rs#11141)forge compile --jsondoes not emit valid JSON on invalid absolute import paths #11149 (fix(forge): consistent handling unresolved imports #11164)forge-lint): improper--only-lintfiltering #11080 (fix(lint): exclude disabled ids in multi-lint passes #11122)forge coverage --report lcovgenerates incorrect output #11183 (fix(coverage): disambiguate duplicate function names #11188)forge verify-contractfails with perplexing error message for unrecognized chains #11186 (fix(forge): improve error messages for etherscan verification failures #11194)Other:
typosCI job failing #11198Solution
PR Checklist