chore(deps): bump to revm 28 #11217
Merged
chore(deps): bump to revm 28 #11217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
changed the title
forge script): repeated vm.createSelectFork with same RPC causes segfault, previously error
zerosnacks
changed the title
forge script): repeated vm.createSelectFork with same RPC causes segfault, previously errorforge script): repeated vm.createSelectFork with same RPC causes segfault
zerosnacks
changed the title
forge script): repeated vm.createSelectFork with same RPC causes segfault
3 tasks
Member
|
can do #11216 |
zerosnacks
commented
Aug 18, 2025
Comment on lines
-211
to
-214
| // Check if an action has already been set (which would null the instruction pointer) | ||
| if interp.bytecode.action.is_some() { | ||
| return; | ||
| } |
Member
Author
There was a problem hiding this comment.
To double check @DaniPopes, this is no longer required in revm 28 per #11216 and we can therefore remove it?
zerosnacks
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse and
yash-atreya
as code owners
onbjerg
approved these changes
Aug 18, 2025
DaniPopes
approved these changes
Aug 18, 2025
MerkleBoy
pushed a commit
to MerkleBoy/foundry
that referenced
this pull request
Sep 17, 2025
* bump revm to 24.0.0 * fix clippy * bump to alloy 1.0.7 * update revm, attempt to fix foundry-rs#11213 * bump incl fix for build issue: bluealloy/revm#2852 * add test to assert segfault no longer occurs * note ticket * bump revm to 28 * bump revm related deps * bump rev alloy-evm clippy * start fixing clippy, quite a few changes :( * fix breaking changes introduced in revm 28 * fix merge conflict * bump foundry-fork-db to 0.17 * fix expected test serialization result change * remove workaround, nulled instruction pointer is now handled gracefully in revm --------- Co-authored-by: grandizzy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor breaking changes, changes should be exact logical equivalents
Possible minor performance regression / new overhead introduced by required boxing of
DecodedTraceStepbut from local benchmarks we see an overall improvementrevm/op-revmto 28revm-inspectorsto revm 28foundry-fork-dbto revm 28Fixes: #11216
Local benchmarks against
uniswap/v4-core:stable/nightly/revm 28ran:
forge test --mt test_fuzz_swap_beforeSwap_returnsDeltaSpecifiedran:
forge test --mt test_fuzz_swap_beforeSwap_returnsDeltaSpecified -vvvv