test(lint): add InlineConfigItem parsing and DisabledRange coverage #11317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add unit tests for InlineConfigItem::parse: - default "all" behavior (with and without parens) - specific lint IDs parsing and trimming - syntax errors (unknown directive, missing closing paren) - invalid IDs reporting - Add InvalidInlineConfigItem Display tests - Add DisabledRange::includes strict vs loose boundary tests No functional changes; test-only.
tiendn
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
|
in this wip PR (soon to be finished) https://github.com/foundry-rs/foundry/pull/10907/files#diff-e43febe7f0bd2bdfe8724234b3559802bc35ebe0ac9cb9bab221c75e5b603e15 we abstract away everything related to inline-config, and upstream it to because of that + the fact that we already test this feature in several lint testdata files such as https://github.com/foundry-rs/foundry/blob/fccc80782bf3da9b770c4e6cf83aaa6d0f6faa7d/crates/lint/testdata/Keccak256.sol i think that we can close this PR... with that being said, i'll defer the decision to others. |
|
@zerosnacks @grandizzy @DaniPopes to decide if we close or not |
|
Closing as above |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
More unittest
Solution
No functional changes; test-only.
PR Checklist