fix(forge): enable fail fast flag #11328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grandizzy
requested review from
DaniPopes,
klkvr,
mattsse,
yash-atreya and
zerosnacks
as code owners
DaniPopes
reviewed
Aug 18, 2025
crates/forge/src/runner.rs
Outdated
|
|
||
| /// Runs all tests for a contract whose names match the provided regular expression | ||
| pub fn run_tests(mut self, filter: &dyn TestFilter) -> SuiteResult { | ||
| pub fn run_tests(mut self, filter: &dyn TestFilter, fail_fast: &FailFast) -> SuiteResult { |
Member
There was a problem hiding this comment.
can we set this in self? it can also be cloned just fine
crates/forge/src/multi_runner.rs
Outdated
| filter: &dyn TestFilter, | ||
| tx: mpsc::Sender<(String, SuiteResult)>, | ||
| show_progress: bool, | ||
| fail_fast: bool, |
MerkleBoy
pushed a commit
to MerkleBoy/foundry
that referenced
this pull request
Sep 17, 2025
* fix(forge): enable fail fast flag * Cleanup after review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
forge test):--fail-fastflag does not work as it is not applied across multiple test suites #6529Solution
PR Checklist